Skip to content

feat: action info for pool parameters #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2025
Merged

feat: action info for pool parameters #1482

merged 4 commits into from
Oct 8, 2025

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Oct 7, 2025 •
edited
Loading

  • convert the pool parameters to action info components in beta mode
  • align contract elements to the center of the line

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
curve-dapp Ready Ready Preview Comment Oct 7, 2025 2:36pm
curve-dapp-storybook Ready Ready Preview Comment Oct 7, 2025 2:36pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
curve-router-api Skipped Skipped Oct 7, 2025 2:36pm

@DanielSchiavini DanielSchiavini marked this pull request as ready for review October 7, 2025 08:38
@vercel vercel bot temporarily deployed to Preview – curve-router-api October 7, 2025 14:34 Inactive
0xAlunara
0xAlunara approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@0xAlunara 0xAlunara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Although not sure if we should mix - with N/A?
image

@DanielSchiavini
Copy link
Collaborator Author

Looking good. Although not sure if we should mix - with N/A? image

I did not change this, so I'll merge it as-is.
Old code:

curve-frontend/apps/main/src/dex/components/PagePool/PoolDetails/PoolStats/PoolTotalStaked.tsx

Lines 19 to 37 in 5e57f7b

<Item>
{t`Total LP Tokens staked:`}{' '}
<strong>
{typeof staked?.gaugeTotalSupply === 'string'
? staked.gaugeTotalSupply
: formatNumber(staked?.gaugeTotalSupply ? weiToEther(Number(staked.gaugeTotalSupply)) : undefined, {
notation: 'compact',
defaultValue: '-',
})}
</strong>
</Item>
<Item>
{t`Staked percent`}:{' '}
<strong>
{typeof staked?.totalStakedPercent === 'string'
? staked.totalStakedPercent
: formatNumber(staked?.totalStakedPercent, { style: 'percent', defaultValue: '-' })}
</strong>
</Item>

New code:

curve-frontend/apps/main/src/dex/components/PagePool/PoolDetails/PoolStats/PoolParameters.tsx

Lines 83 to 101 in ea88aaf

<ActionInfo
label={t`Total LP Tokens staked:`}
value={
staked?.gaugeTotalSupply === 'string'
? staked.gaugeTotalSupply
: formatNumber(staked?.gaugeTotalSupply && weiToEther(+staked.gaugeTotalSupply), {
notation: 'compact',
defaultValue: '-',
})
}
/>
<ActionInfo
label={t`Staked percent`}
value={
typeof staked?.totalStakedPercent === 'string'
? staked.totalStakedPercent
: formatNumber(staked?.totalStakedPercent, { style: 'percent', defaultValue: '-' })
}
/>

@DanielSchiavini DanielSchiavini merged commit 680f17e into main Oct 8, 2025
17 checks passed
@DanielSchiavini DanielSchiavini deleted the feat/action-info branch October 8, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xPearce 0xPearce 0xPearce approved these changes

@0xAlunara 0xAlunara 0xAlunara approved these changes

@0xtutti 0xtutti 0xtutti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanielSchiavini @0xPearce @0xAlunara @0xtutti